Web auth #284
Closed
Web auth #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LOCUST_USERNAME and LOCUST_PASSWORD environment variable pair.
|
Hmm, I can see the use case for this, but I'm concerned it's adding feature bloat to address a problem that is better handled through other means. e.g. you can slap nginx with basic auth in front of it. There are a million other solutions to apply authentication and I feel like it's best left to users to address their own unique cases. |
Closed
|
The reason we added this was to essentially support a shared secret. We had locust running in the cloud on AWS and wanted to ensure there was little ability to access to page without the credentials. It's fine if you do not want the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on code / comments in #278