Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastResponse: Detect response text encoding when no information is present on the response headers. #2485

Merged

Conversation

MiltiadisKoutsokeras
Copy link
Contributor

If no response headers are present or do not contain response encoding, use charset_normalizer.detect to detect the encoding from response content bytes.

…sponse encoding, use charset_normalizer.detect to detect the encoding from response content bytes
@cyberw
Copy link
Collaborator

cyberw commented Nov 24, 2023

I like this one the best, because it matches python-requests. Can you fix the typing issue? The regular tests are unstable at the moment, feel free to ignore that...

@cyberw cyberw merged commit 687b34a into locustio:master Nov 27, 2023
12 checks passed
@MiltiadisKoutsokeras
Copy link
Contributor Author

Thank you for accepting this. We will integrate it in our framework as soon as it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants