Add --expect-workers-max-wait parameter #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while len(runner.clients.ready) < options.expect_workers: | ||
| if options.expect_workers_max_wait and options.expect_workers_max_wait < time.monotonic() - start_time: | ||
| logger.error("Gave up waiting for workers to connect.") |
There was a problem hiding this comment.
could you add
if runner is not None:
runner.quit()
here to remove all workers, if any?
cyberw
added a commit
that referenced
this pull request
Nov 8, 2021
|
This error occurred when I run this command： |
|
Use --expect-workers not --expect-worker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful in CI, where you dont want to wait forever if your workers fail to connect.