Handle user classes with weight = 0 #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberw
reviewed
Aug 20, 2021
| Remove user classes having a weight of zero. | ||
| """ | ||
| if len(self.user_classes) == 0: | ||
| # Preserve previous behaviour that allowed no user classes to be specified. |
There was a problem hiding this comment.
Was it ok to specify no user classes before? I dont know when that should not be considered an error?
There was a problem hiding this comment.
I agree that this should make locust fail fast because it is invalid. The reason I put it there is that otherwise more than 20 tests are failing. If I remove this condition, I'll have to update all those tests so that they contain fake user class.
There was a problem hiding this comment.
Ok! Yea I guess we still fail in main.py on line 165 if you actually launch locust proper without any classes. Ready to merge, or is there something else that is WIP?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP