Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --html option to generate HTML report #1611

Closed
wants to merge 2 commits into from
Closed

Added --html option to generate HTML report #1611

wants to merge 2 commits into from

Conversation

vsapronov
Copy link

This is very useful when running locust in headless mode.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #1611 into master will decrease coverage by 0.01%.
The diff coverage is 90.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
- Coverage   82.69%   82.67%   -0.02%     
==========================================
  Files          28       29       +1     
  Lines        2565     2586      +21     
  Branches      390      391       +1     
==========================================
+ Hits         2121     2138      +17     
- Misses        349      354       +5     
+ Partials       95       94       -1     
Impacted Files Coverage Δ
locust/main.py 21.17% <20.00%> (-0.03%) ⬇️
locust/html.py 97.72% <97.72%> (ø)
locust/argument_parser.py 77.39% <100.00%> (+0.19%) ⬆️
locust/web.py 90.38% <100.00%> (-1.18%) ⬇️
locust/user/task.py 96.27% <0.00%> (-0.54%) ⬇️
locust/runners.py 85.96% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f21896...51b7a95. Read the comment docs.

@cyberw
Copy link
Collaborator

cyberw commented Nov 1, 2020

Cool stuff! Can you add a test case?

@vsapronov
Copy link
Author

Cool stuff! Can you add a test case?

Hi, I think the functionality that I have extracted is under tests that are hitting /stats/report here: https://github.com/locustio/locust/blob/master/locust/test/test_web.py#L300-L345.

@cyberw
Copy link
Collaborator

cyberw commented Nov 2, 2020

Can you add a "real" test in test_main.py ? I agree that some of the underlying features are tested, but not the parsing of the parameter, writing to file etc.

@cyberw
Copy link
Collaborator

cyberw commented Nov 11, 2020

@vsapronov ?

@cyberw
Copy link
Collaborator

cyberw commented Nov 24, 2020

replaced by #1637

@cyberw cyberw closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants