Gracefully handle exceptions in event listeners #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer adding some logging, but looking at the file I didn't see how that could be accomplished |
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
+ Coverage 81.18% 81.32% +0.13%
==========================================
Files 27 27
Lines 2365 2377 +12
Branches 365 365
==========================================
+ Hits 1920 1933 +13
Misses 354 354
+ Partials 91 90 -1
Continue to review full report at Codecov.
|
cyberw
added a commit
that referenced
this pull request
Jul 4, 2020
…nstead of importing it into a local variable and changing the copy). Print the whole traceback of the exception.
cyberw
added a commit
that referenced
this pull request
Aug 6, 2020
…d in event handlers would also be caught. Re-raise those exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception thrown during the handling of an event will stop the execution of other listeners.
Solves #1461