Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 3 remaining instances of slave to worker #1400

Merged
merged 3 commits into from
May 28, 2020

Conversation

ibrahima
Copy link
Contributor

Just noticed this when I was browsing the documentation.

@ibrahima
Copy link
Contributor Author

Actually, there's probably a couple more that should be changed:

https://github.com/locustio/locust/search?q=slave&unscoped_q=slave

logger.info("Reset connection to slave")

# check that slave nodes have started locusts

I think the other instances are places where the old options need to be handled with a deprecation warning.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #1400 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
- Coverage   81.19%   81.11%   -0.09%     
==========================================
  Files          26       26              
  Lines        2335     2335              
  Branches      361      361              
==========================================
- Hits         1896     1894       -2     
- Misses        347      348       +1     
- Partials       92       93       +1     
Impacted Files Coverage Δ
locust/runners.py 80.83% <0.00%> (ø)
locust/user/task.py 96.17% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a350d...d22a03f. Read the comment docs.

@ibrahima ibrahima changed the title Rename one more instance of slave to worker Rename 3 remaining instances of slave to worker May 28, 2020
@cyberw
Copy link
Collaborator

cyberw commented May 28, 2020

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants