Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a more descriptive error when the Locust or TaskSet has no tasks. #1287

Merged

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Mar 11, 2020

Give the user gets a better exception than IndexError: Cannot choose from an empty sequence

Should help with user problems like this one for instance https://stackoverflow.com/questions/60629518/error-while-executing-basic-code-in-locust

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #1287 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   80.12%   80.28%   +0.16%     
==========================================
  Files          23       23              
  Lines        2068     2070       +2     
  Branches      319      320       +1     
==========================================
+ Hits         1657     1662       +5     
+ Misses        333      330       -3     
  Partials       78       78
Impacted Files Coverage Δ
locust/core.py 91.32% <100%> (+0.07%) ⬆️
locust/rpc/zmqrpc.py 92.1% <0%> (+7.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268a9d5...b330585. Read the comment docs.

@cyberw
Copy link
Collaborator Author

cyberw commented Mar 16, 2020

Merging this unless someone objects today :) @heyman

@heyman
Copy link
Member

heyman commented Mar 16, 2020

Looks good to me!

@cyberw cyberw merged commit d8be05a into master Mar 16, 2020
@heyman heyman deleted the generate-more-descriptive-error-when-user-forgot-do-define-tasks branch April 14, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants