Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save failures.csv in --no-web mode #1245

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Conversation

ajt89
Copy link
Contributor

@ajt89 ajt89 commented Jan 27, 2020

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #1245 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
+ Coverage   78.49%   78.66%   +0.17%     
==========================================
  Files          20       20              
  Lines        2004     2006       +2     
  Branches      316      316              
==========================================
+ Hits         1573     1578       +5     
+ Misses        354      351       -3     
  Partials       77       77
Impacted Files Coverage Δ
locust/stats.py 85.77% <100%> (+1.42%) ⬆️
locust/core.py 92.18% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2d915...4a9fb23. Read the comment docs.

@cyberw
Copy link
Collaborator

cyberw commented Jan 27, 2020

Thanks! Is there a test that covers this? Would you consider adding one? Just checking the existence of the files is enough.

@schorba
Copy link

schorba commented Jan 27, 2020

Thank you a lot !

@cyberw cyberw merged commit 13bf7ef into locustio:master Jan 28, 2020
@vstepanov-lohika-tix
Copy link
Contributor

Very useful update, thanks

@ajt89 ajt89 deleted the no-web-failures-file branch February 19, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants