Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get encoding from content-type header instead of autodetecting using chardet (which is slow) #1194

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Dec 12, 2019

Default to UTF-8. Fixes #1193

@cyberw cyberw requested a review from heyman December 12, 2019 18:42
@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1194 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
+ Coverage   78.46%   78.49%   +0.02%     
==========================================
  Files          20       20              
  Lines        1960     1958       -2     
  Branches      307      307              
==========================================
- Hits         1538     1537       -1     
+ Misses        342      341       -1     
  Partials       80       80
Impacted Files Coverage Δ
locust/contrib/fasthttp.py 88.43% <100%> (-0.14%) ⬇️
locust/runners.py 78.58% <0%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73382f4...16e49f3. Read the comment docs.

@cyberw cyberw merged commit 8348106 into master Dec 17, 2019
@mbeacom mbeacom deleted the fix-encoding-detection-in-fasthttplocust branch December 21, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastHttpLocust is very slow at returning the response text
1 participant