Add toolbox control for for downloading chart as png #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
- Coverage 79.57% 79.31% -0.27%
==========================================
Files 20 20
Lines 1895 1895
Branches 294 294
==========================================
- Hits 1508 1503 -5
- Misses 315 320 +5
Partials 72 72
Continue to review full report at Codecov.
|
|
nice! |
|
Hi, can I download chart with http API? |
I don't think so, this PR just add a config item of echartsjs, which just works on the frontend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find myself taking screenshots of the charts quite often, this adds a small button in the top right corner of the charts for downloading them as PNG images.