Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table layout fix to use available space better #1114

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Conversation

heyman
Copy link
Member

@heyman heyman commented Oct 21, 2019

This PR removes the table-layout: fixed CSS property from the stats table in the web UI, in order to make better use of the available space.

The table-layout:fixed property was added by #962 (which is a PR for #938), so this PR will partly revert those changes. However I'm still able to see the whole table by scrolling the page horizontally after these changes.

Before:
image

After:
image

…the table layout use the available space better
@heyman heyman changed the title Stats table layout fix to use available space better Table layout fix to use available space better Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #1114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   72.69%   72.69%           
=======================================
  Files          18       18           
  Lines        1765     1765           
  Branches      262      262           
=======================================
  Hits         1283     1283           
  Misses        420      420           
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8b925...e816fa0. Read the comment docs.

@heyman heyman merged commit e598724 into master Oct 21, 2019
@max-rocket-internet
Copy link
Contributor

Nice!

@cyberw cyberw deleted the table-layout-fix branch November 7, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants