Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min and max response times rounded to nearest int in web view #1089

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

ajt89
Copy link
Contributor

@ajt89 ajt89 commented Sep 23, 2019

@cgoldberg
Copy link
Member

I'm not sure round() is sufficient here for both Python2 and Python3, since they behave differently...

For example:

Python 2:

>>> round(0.5)
1.0
>>> round(1.5)
2.0

Python 3:

>>> round(0.5)
0
>>> round(1.5)
2

thoughts?

@ajt89
Copy link
Contributor Author

ajt89 commented Sep 23, 2019

@cgoldberg Good point. Should I create a rounding function in the util folder similar to this? https://stackoverflow.com/questions/31818050/round-number-to-nearest-integer

@cgoldberg cgoldberg merged commit 14bd777 into locustio:master Sep 24, 2019
@cgoldberg
Copy link
Member

👍 nice... thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants