Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Total Requests Per Second plot #1060

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

williamlhunter
Copy link
Contributor

@williamlhunter williamlhunter commented Aug 6, 2019

Fixes the plot when there are too many unique urls.

#1059
#889

The total stats block, which is usually located at the end of the list of stats, was getting truncated whenever there were too many URLs that were being requested. Here I add the total stats back to the end of the report.

@jonyoder
Copy link

jonyoder commented Aug 7, 2019

We've run into this bug while testing, too. Our load tests use a smart randomized URL which can result in thousands of unique URLs. If this fix is correct, I'd love to see it merged.

@cgoldberg
Copy link
Member

If this fix is correct, I'd love to see it merged.

I don't think it is, and the original issue is still much too vague.

@williamlhunter
Copy link
Contributor Author

I tested it, and it does fix the issue (at least for me).

Furthermore, let me know how I'm being vague and I'll elaborate.

@RyanW89
Copy link

RyanW89 commented Aug 12, 2019

I left this comment on the original thread, you need to add name="RequestName" to your request. The requests will be aggregated on this, rather that the URL.

@williamlhunter
Copy link
Contributor Author

I left this comment on the original thread, you need to add name="RequestName" to your request. The requests will be aggregated on this, rather that the URL.

This did fix my problem, but I still feel that the fix is warranted for users who have more than 500 categories.

@cyberw cyberw merged commit 435f349 into locustio:master Oct 20, 2019
@cyberw
Copy link
Collaborator

cyberw commented Oct 20, 2019

Thanks @williamlhunter !

@heyman
Copy link
Member

heyman commented Oct 20, 2019

Nice!

I also think it could be nice to display some kind of warning notice in the Web UI if the stats have been truncated. Both to inform the user that it has happended, and also mentioning that it might affect performance with very large amount of stats entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants