Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-lit] Attribute Error in lit internal shell #102399

Closed
5 tasks done
Harini0924 opened this issue Aug 7, 2024 · 1 comment · Fixed by #103012 or #102988
Closed
5 tasks done

[llvm-lit] Attribute Error in lit internal shell #102399

Harini0924 opened this issue Aug 7, 2024 · 1 comment · Fixed by #103012 or #102988

Comments

@Harini0924
Copy link
Contributor

Harini0924 commented Aug 7, 2024

When using the internal shell with this command LIT_USE_INTERNAL_SHELL=1 an AttributeError is displayed.
Error displayed:

line 1096, in executeScriptInternal
    result.command.args[0] == "@echo"
    ^^^^^^^^^^^^^^^^^^^
AttributeError: 'Seq' object has no attribute 'args'

Fixed this issue by adding the REQUIRES: shell directive because these tests use features that run commands in the background with &, which is not supported with lit's internal shell.

Files with failures in BOLT:

  • bolt/test/permission.test

Files with failures in compiler-rt:

  • compiler-rt/test/fuzzer/fork-sigusr.test
  • compiler-rt/test/fuzzer/merge-sigusr.test
  • compiler-rt/test/fuzzer/sigint.test
  • compiler-rt/test/fuzzer/sigusr.test
@llvmbot
Copy link
Collaborator

llvmbot commented Aug 25, 2024

@llvm/issue-subscribers-bolt

Author: None (Harini0924)

The `executeScriptInternal` function in the lit’s `TestRunner.py` needs modification to address an `AttributeError` occurring in multiple test cases, particularly those related to BOLT and libFuzzer. The error indicates that the result.command object, a `Seq` object, is being accessed incorrectly as if it had an args attribute. Error displayed: ``` line 1096, in executeScriptInternal result.command.args[0] == "@echo" ^^^^^^^^^^^^^^^^^^^ AttributeError: 'Seq' object has no attribute 'args' ```

@Harini0924 Harini0924 self-assigned this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment