Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Remove support for circt.Intrinsic annotation. #6857

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[FIRRTL] Remove support for circt.Intrinsic annotation. #6857

merged 2 commits into from
Mar 20, 2024

Conversation

dtzSiFive
Copy link
Contributor

Documentation indicates this was intended to be removed once FIRRTL language supports intrinsics, and we have intmodule's now.

@dtzSiFive
[FIRRTL] Remove support for circt.Intrinsic annotation.
d51b9de 
Documentation indicates this was intended to be removed once
FIRRTL language supports intrinsics, and we have intmodule's now.
fabianschuiki
fabianschuiki approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I haven't seen any uses of circt.Intrinsic out in the wild anymore. Everything seems to go through intmodule. Otherwise we can always revert the PR.

@dtzSiFive
Copy link
Contributor Author

Looks like it's unused but technically not removed from Chisel presently.
I had checked for the string but right it's the class name. It's dead regardless.

PR removing it here:
chipsalliance/chisel#3945 .

@dtzSiFive dtzSiFive merged commit e4b78d7 into llvm:main Mar 20, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the feature/remove-circt-intrinsic-anno branch March 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @fabianschuiki