Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): 'bdelete' filename containing whitespaces #277

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Oct 11, 2023

Regresion test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • FzfxFiles
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between restricted/unrestricted mode, and the lines count is consistent when press multiple times.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files.
    • Both fd and find works.
  • FzfxLiveGrep
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between restricted/unrestricted mode, and the lines count is consistent when press multiple times.
    • Use -w to match word only, use -g *.lua to search only lua files.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files when searching hello and goodbye words.
    • Both rg and grep works.
  • FzfxBuffers
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-D to delete buffers.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to open file.
  • FzfxGFiles
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-W to switch between workspace/current folder mode.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to open file.
  • FzfxGCommits
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-A to switch between git repo commits/current buffer commits.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to copy commit hash.
  • FzfxGBlame
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to copy commit hash.
  • FzfxLspDiagnostics
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-W to switch between workspace/current buffer diagnostics.
    • Use V/W/P variants (visual selection, cursor word, yank text).
    • Press ESC to quit, ENTER to open file.
  • FzfxLspDefinitions, FzfxLspTypeDefinitions, FzfxLspReferences, FzfxLspImplementations
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Go to definitions/references (this is the most 2 easiest use case when developing this lua plugin with lua_ls).
    • Press ESC to quit, ENTER to open file.
  • FzfxFileExplorer
    • Press CTRL-N/CTRL-P to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between filter/include hidden files mode.
    • Press ALT-L/ALT-H to cd into folder and cd upper folder.
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files.
    • Both eza and ls works.
  • Backward Compatible
    • Open with nvim -u ./test/minimal_buffers_deprecate_init.lua and test FzfxBuffers.
    • Open with nvim -u ./test/minimal_files_deprecate_init.lua and test FzfxFiles.
    • Open with nvim -u ./test/minimal_git_branches_deprecate_init.lua and test FzfxGBranches.
    • Open with nvim -u ./test/minimal_git_commits_deprecate_init.lua and test FzfxGCommits.
    • Open with nvim -u ./test/minimal_git_files_deprecate_init.lua and test FzfxGFiles.
    • Open with nvim -u ./test/minimal_live_grep_deprecate_init.lua and test FzfxLiveGrep.

@github-actions github-actions bot added the fix label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lua/fzfx/line_helpers.lua 100.00% <ø> (+32.83%) ⬆️
lua/fzfx/actions.lua 54.12% <42.10%> (+0.91%) ⬆️

📢 Thoughts on this report? Let us know!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant