Print count of orphaned tasks and orphaned task locks in the log message #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaheshw
requested changes
Jul 28, 2021
surajkn
changed the title
surajkn
changed the title
vmaheshw
reviewed
Aug 3, 2021
| @@ -1075,7 +1075,8 @@ public int cleanUpOrphanConnectorTasks(boolean cleanUpOrphanTasksInConnector) { | |||
| connectorTaskList.remove(KeyBuilder.DATASTREAM_TASK_LOCK_ROOT_NAME); | |||
|
|
|||
| if (connectorTaskList.size() > 0) { | |||
| LOG.warn("Found orphan tasks: {} in connector: {}", connectorTaskList, connector); | |||
| LOG.warn("Found {} number of orphan tasks: {} in connector: {}", connectorTaskList.size(), | |||
There was a problem hiding this comment.
nit pick: Found 10 number of orphan task does not sound right. How about Found 10 orphan tasks:?
| @@ -1151,7 +1152,8 @@ public int cleanUpOrphanConnectorTaskLocks(boolean cleanUpOrphanTaskLocksInConne | |||
| }); | |||
|
|
|||
| if (orphanLockList.size() > 0) { | |||
| LOG.warn("Found orphan task locks: {} in connector: {}", orphanLockList, connector); | |||
| LOG.warn("Found {} number of orphan task locks: {} in connector: {}", orphanLockList.size(), | |||
Print count of orphaned tasks and orphaned task locks in the log message in addition to the actual tasks/locks and connector info.
surajkn
force-pushed
the
print_orphan_task_count
branch
from
e18c46a
to
ce37b39
Compare
shrinandthakkar
approved these changes
Aug 4, 2021
vmaheshw
pushed a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
Print count of orphaned tasks and orphaned task locks in the log message in addition to the actual tasks/locks and connector info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print count of orphaned tasks and task logs in addition to printing the actual tasks, task locks and connector info in ZkAdapter while cleaning up orphan tasks.
Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md