Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null default values are invalid for many settings expecting integers, e.g. ttl #302

Open
tacman opened this issue Mar 23, 2024 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Mar 23, 2024

Absent a recipe with default values, at a minimum the bundle should be able to create a valid config file, even if everything is disabled by default.

After installation for version 3 and changing the class name in bundles.php, run

bin/console config:dump-reference liip_monitor > config/packages/monitor.yaml 
bin/console cache:clear

It seems like the configuration should contain reasonable values for ttl, warning_duration, etc.

@kbond
Copy link
Collaborator

kbond commented Apr 1, 2024

Hmm, the null value means "don't use this feature"

bin/console config:dump-reference liip_monitor > config/packages/monitor.yaml

I don't think you should configure bundles this way. Just add the config you require. That being said, I'll look into why using null causes an error - can you show the exception you see?

@tacman
Copy link
Contributor Author

tacman commented Jul 23, 2024

This is less pressing now that there's a recipe, but still I don't think that command should generate an invalid configuration.

In IntegerNode.php line 26:

Invalid type for path "liip_monitor.checks.groups.name.messenger_transports.name.critical_threshold". Expected "int", but got "null".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants