Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons - Fill Button with 3D styles to 3D Block Style #109

Closed
Justinabes007 opened this issue Apr 5, 2024 · 1 comment
Closed

Buttons - Fill Button with 3D styles to 3D Block Style #109

Justinabes007 opened this issue Apr 5, 2024 · 1 comment
Assignees
Labels
Needs Dev Anything that needs development.
Milestone

Comments

@Justinabes007
Copy link
Contributor

Describe the bug
Currently the default Fill Button Block style has been styled with Borders including Hover effects as per the Style Guide.

In Practise this is not always ideal if the Button is within a Card or Box Element as it causes extra Borders & Hover display issues.

Adjusting all the current variations of the Fill Button to move to a New Block style will require planning to map and replace the current Styles.

Each of the following Block Styles would need to be updated and duplicated:

  1. Fill
  2. Outline
  3. Rounded
  4. Pill

From each Button Block style, each Colour variation X 5 + each Hover state + Contract/Base background would need to be updated and replaced with new default style and the current Styles moved to a New 3D Block Button style.

Screenshots:
Screenshot 2024-04-05 at 14 42 00

Expected behavior

  1. Fill Button shouldn't contain Borders or 3D hover states only the colour states within the same Colour Pallete
  2. The current Fill Button styles moved to a 3D Block styles
Screenshot 2024-04-05 at 14 45 58
@Justinabes007 Justinabes007 added the Needs Dev Anything that needs development. label Apr 5, 2024
@Justinabes007 Justinabes007 added this to the 1.3.1 milestone Apr 5, 2024
@Justinabes007 Justinabes007 self-assigned this Apr 5, 2024
@krugazul krugazul modified the milestones: 1.3.1, 1.4 Jul 17, 2024
@krugazul
Copy link
Contributor

@Justinabes007 I have tested the buttons and checked the code from the relevant branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Anything that needs development.
Projects
None yet
Development

No branches or pull requests

2 participants