Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnwallet+lnd: support watch-only initialization for lnd nodes #3943

Closed
3 tasks done
Roasbeef opened this issue Jan 21, 2020 · 3 comments · Fixed by #5047
Closed
3 tasks done

lnwallet+lnd: support watch-only initialization for lnd nodes #3943

Roasbeef opened this issue Jan 21, 2020 · 3 comments · Fixed by #5047
Labels
advanced Issues suitable for very experienced developers P1 MUST be fixed or reviewed recovery Related to the backup/restoration of LND data (e.g. wallet seeds) safety General label for issues/PRs related to the safety of using the software v0.13 wallet The wallet (lnwallet) which LND uses
Milestone

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Jan 21, 2020

This issue is related to this on going btcwallet PR which adds watch-only support to btcwallet as well as our issue tracking PSBT integration within lnd, and finally #3929 . Once those items are carried out lnd will be able to operate in a mode wherein it requires no private key material to be accessed within the main process. As a result, we'll need a slightly different initialization mode for lnd in order to support this new operating mode. As is, when creating a new lnd instance you need to either provide raw entropy which is used to derive a master private key, or an aezeed. What we need instead, is a new more which accepts a series of xpubs, which are them imported into the internal wallet.

Steps to Completion

Note that we'll need to complete #3929 before this issue can be fully implemented.

@Roasbeef Roasbeef added wallet The wallet (lnwallet) which LND uses advanced Issues suitable for very experienced developers safety General label for issues/PRs related to the safety of using the software recovery Related to the backup/restoration of LND data (e.g. wallet seeds) labels Jan 21, 2020
@Roasbeef Roasbeef added this to the 0.10.0 milestone Jan 21, 2020
@Roasbeef Roasbeef modified the milestones: 0.10.0, 0.11.0 Feb 26, 2020
@Roasbeef
Copy link
Member Author

btcsuite/btcwallet#667 has been merged now, which unblocks this PR once #3929 is in, although they can be worked on concurrently.

@guggero guggero removed their assignment May 15, 2020
@Roasbeef Roasbeef modified the milestones: 0.11.0, 0.12.0 Jun 30, 2020
@Roasbeef Roasbeef added the v0.12 label Jul 22, 2020
@Roasbeef Roasbeef removed this from the 0.12.0 milestone Nov 24, 2020
@wpaulino wpaulino added v0.13 and removed v0.12 labels Jan 28, 2021
@wpaulino wpaulino added the P1 MUST be fixed or reviewed label Jan 28, 2021
@Roasbeef
Copy link
Member Author

Roasbeef commented Apr 6, 2021

Keeping this open for now as the second point to extend InitWallet to allow the relevant key families ti be passed in isn't yet resolved. This is the missing gap that would allow stuff like lnd just having the raw account xpubs for the multi-sig keys with signing being done in a remote/detached manner.

@Roasbeef Roasbeef reopened this Apr 6, 2021
@Roasbeef Roasbeef added this to the v0.14.0 milestone Apr 6, 2021
@wpaulino wpaulino removed their assignment Aug 30, 2021
@Roasbeef
Copy link
Member Author

Closing this as the final item is being tracked in a new issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Issues suitable for very experienced developers P1 MUST be fixed or reviewed recovery Related to the backup/restoration of LND data (e.g. wallet seeds) safety General label for issues/PRs related to the safety of using the software v0.13 wallet The wallet (lnwallet) which LND uses
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants