Pgn error catching #1034
Merged
Pgn error catching #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttackingOrDefending
approved these changes
Oct 13, 2024
AttackingOrDefending
merged commit c0ae365
into
lichess-bot-devs:master
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
An exception raised within the
write_pgn_record()thread will stop any more PGN records from being written. This PR catches all exceptions and logs them so that future games will be saved to files.In the case of an exception being raised from
pgn_queue.get()(usually when Ctrl-C is pressed), theInterruptedErroris caught and ignored. Some additional logic ensures thattask_done()is called for every successfulget()call.Related Issues:
N/A
Checklist:
Screenshots/logs (if applicable):
N/A