windows: fix race condition with exception-based thread naming. #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8849 changed the Windows thread naming code to always run the legacy RaiseException path. It also introduced an exception handler that's meant to stop that exception from being accidentally handled by outside code.
However the new exception handler continues execution for any exception that's raised in the brief time that the handler is active. The handler is activated briefly during thread setup. This ends up being a problem if, for example, the main thread starts a new thread and then immediately causes an exception that's meant to be properly handled instead of continued.
In practice in my app that uses LuaJIT it occasionally caused a panic error inside LuaJIT during my app's startup. Here's an example: https://github.com/love2d/love/actions/runs/11376760949/job/31650135750
To avoid the issue, this PR changes the thread name exception handler to only continue from the exception if the exception code is the thread name one. In other cases it hands things off to the next handler.
Existing Issue(s)
N/A