Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EGL Surface not set for foreign X11 windows #10611

Open
CasualPokePlayer opened this issue Aug 28, 2024 · 0 comments
Open

EGL Surface not set for foreign X11 windows #10611

CasualPokePlayer opened this issue Aug 28, 2024 · 0 comments
Assignees
@icculus
Milestone
3.2.0

Comments

@CasualPokePlayer
Copy link

SDL/src/video/x11/SDL_x11window.c

Line 651 in 4eac44b

windowdata->egl_surface = SDL_EGL_CreateSurface(_this, (NativeWindowType)w);

It seems windowdata->egl_surface is only ever set for X11 windows created by SDL, not any foreign windows (i.e. with X11_CreateWindowFrom), preventing SDL's EGL impl from being used with foreign X11 windows.

Probably can have this surface creation just be moved to SetupWindowData?

(This issue affects both SDL3 and SDL2, but for my purposes I'd want to have this fixed in SDL2 too).
CasualPokePlayer added a commit to CasualPokePlayer/SDL that referenced this issue Aug 31, 2024
@CasualPokePlayer
Set EGL surface for foreign X11 windows
b905583 
Also slightly changes up the cleanup code for SetupWindowData, to avoid copy pasting.

See libsdl-org#10611
@CasualPokePlayer CasualPokePlayer mentioned this issue Aug 31, 2024
Open
@slouken slouken added this to the 3.2.0 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@icculus @slouken @CasualPokePlayer