Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Envelope and PeerRecord protobufs to latest version #333

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

thomaseizinger
Copy link
Contributor

These protobuf definitions are taken from the go-libp2p repo.

Fixes #329.

cc @mxinden

These protobuf definitions are taken from the go-libp2p repo.
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Thomas! This looks good to me. I want to give @vasco-santos a chance to review as well to ensure js-libp2p is aligned too.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from JS side 👌🏼 thanks for pinging

@mxinden mxinden merged commit a27dd9e into libp2p:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Signed Envelopes] Protobuf description not valid
3 participants