fix(allowblocklist): correctly remove Peer from sets
#3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
ty @thomaseizinger happy to not claim authorship, it's your code so please go ahead with the PR :) |
mxinden
approved these changes
Apr 19, 2023
|
Failure on rust-libp2p and zig-libp2p: https://github.com/libp2p/rust-libp2p/actions/runs/4729488489/jobs/8392061915?pr=3789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we reinserted the
Peerin the "undo" function which is obviously wrong. This patch fixes the behaviour to be correct and adds two regression tests.Notes & open questions
Thanks to @divagant-martian for discovering this bug. Happy to add you as a co-author if you let me know which email to use.
Change checklist