feat: Add compact protobuf format #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Why not use CBOR? |
|
Hmmm... which one is smaller? |
mkg20001
force-pushed
the
master
branch
2 times, most recently
from
9b829bb
to
b79235f
Compare
pgte
suggested changes
Jun 21, 2018
|
@pgte Requested changes applied. Could you please re-review? |
pgte
previously requested changes
Jun 21, 2018
|
Also, Travis CI is complaining.. |
|
@pgte Applied requested changes, additionally fixed some other things |
|
@mkg20001 great, thank you! |
|
@pgte Yes, although it's unclear to me what exactly is wrong with the commit message. It only shows it's not in the required format, not where exactly the error is |
|
@victorbjelkholm could you help clarifying this question about the commit message? |
|
Updated this PR to async/await |
|
@jacobheun Thx, changes commited |
jacobheun
reviewed
Jul 12, 2019
|
released in 0.13.2 |
|
Nice 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a significantly smaller (about 30%) protobuf format
It's smaller because
.toJSON()encodes the binary keys as base64 which makes it bigger and is sometimes not needed - like when transferring the id over the networkAdditionally an
excludePrivoption is added because the removal of the private key is not as easy as in json