Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.createFromJSON does not check if public key and id match #79

Closed
mkg20001 opened this issue Jun 15, 2018 · 2 comments
Closed

.createFromJSON does not check if public key and id match #79

mkg20001 opened this issue Jun 15, 2018 · 2 comments
Labels
status/ready Ready to be worked

Comments

@mkg20001
Copy link
Member

.createFromJSON only matches private key => id and private key => public key

Because the private key is optional the public key will not get matched against the id if it is missing.
@mkg20001 mkg20001 mentioned this issue Jun 17, 2018
Open
mkg20001 added a commit to mkg20001/js-peer-id that referenced this issue Jun 21, 2018
@mkg20001
fix: libp2p#79 check if pubKey equals id and de-dup some code
a1af67c
mkg20001 added a commit to mkg20001/js-peer-id that referenced this issue Jun 21, 2018
@mkg20001
fix: libp2p#79 check if pubKey equals id and de-dup some code
9849450
mkg20001 added a commit to mkg20001/js-peer-id that referenced this issue Jun 21, 2018
@mkg20001
fix: libp2p#79 check if pubkey equals id and de-dup some code
0ef7c33
mkg20001 added a commit to mkg20001/js-peer-id that referenced this issue Jul 28, 2018
@mkg20001
fix: libp2p#79 check if pubkey equals id and de-dup some code
2448e21
@daviddias daviddias added the status/ready Ready to be worked label Aug 25, 2018
@mkg20001
Copy link
Member Author

Is this fixed now?

@jacobheun
Copy link
Contributor

Yes, it looks like it. We verify the private and pub key digests match (if there is a public key) and that the id and priv digest match, which inherently validate the public and id match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacobheun @daviddias @mkg20001