Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make queue job args non-optional #2743

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

achingbrain
Copy link
Member

There will always be an abort signal passed to a queue job so the options arg will always be present.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

There will always be an abort signal passed to a queue job so the
options arg will always be present.
@achingbrain achingbrain requested a review from a team as a code owner October 2, 2024 08:17
@achingbrain achingbrain merged commit 80e798c into main Oct 2, 2024
21 checks passed
@achingbrain achingbrain deleted the fix/make-queue-options-non-optional branch October 2, 2024 09:35
@achingbrain achingbrain mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant