Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add inbound rpc request metrics #2721

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: add inbound rpc request metrics #2721

merged 1 commit into from
Sep 25, 2024

Conversation

achingbrain
Copy link
Member

Adds a libp2p_kad_dht_inbound_rpc_requests counter group that has labels for success/error outcomes of each RPC call type.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
feat: add inbound rpc request metrics
fa15571 
Adds a `libp2p_kad_dht_inbound_rpc_requests` counter group that has
labels for success/error outcomes of each RPC call type.
@achingbrain achingbrain requested a review from a team as a code owner September 24, 2024 18:45
@achingbrain achingbrain merged commit fa83ee1 into main Sep 25, 2024
21 checks passed
@achingbrain achingbrain deleted the feat/add-rpc-metrics branch September 25, 2024 06:17
@achingbrain achingbrain mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad