refactor!: move fetch protocol into separate package #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
Extract the keychain into it's own package.
Co-authored-by: chad <chad.nehemiah94@gmail.com>
A [PeerInfo](https://docs.libp2p.io/concepts/fundamentals/peers/#peer-info) is a libp2p object that combines a PeerID and some Multiaddrs. We also add a list of protocols. This was a mistake because protocols are exchanged during Identify but the PeerInfo object is used for peer discovery. This is evident because we set the protocol list to an empty array everywhere. PeerInfo is useful for exchanging peer data with other nodes, if we need a more fleshed-out peer representation we'd use the `Peer` interface from the peer store. BREAKING CHANGE: the `.protocols` property has been removed from the `PeerInfo` interface
We have an `isStarted` method on the `Startable` interface but we only really use it in tests. Our implementations tend to guard on being started twice so it just adds noise to every implementation. BREAKING CHANGE: the `isStarted` method has been removed from the `Startable` interface
- Move pnet module to a separate package - Related to libp2p#1913
achingbrain
force-pushed
the
release-v1.0
branch
from
66fbdb9
to
ce6ee74
Compare
achingbrain
force-pushed
the
remove-fetch
branch
3 times, most recently
from
60165d4
to
0e04402
Compare
achingbrain
force-pushed
the
remove-fetch
branch
from
0e04402
to
0cb7368
Compare
achingbrain
force-pushed
the
release-v1.0
branch
5 times, most recently
from
9a15061
to
e99f66b
Compare
|
Superseded by #2223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Description
Notes & open questions
Change checklist