Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@libp2p/protocol-perf): ensure only client calls measure performance #1960

Merged
merged 14 commits into from
Aug 14, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 11, 2023

According to the spec perf is a client-driven set of benchmarks., therefore the server need not call the measurePerfomance method. This PR fixes two things:

  • Only client calls the measurePerformance method
  • The server node must remaining i.e. not stopped as there are multiple perf runs against a single server process. The test runner will end the server process.

@maschad maschad changed the title fix(protocol-perf): output close listening node after latency is output fix(protocol-perf): don't shutdown node Aug 11, 2023
@maschad maschad changed the title fix(protocol-perf): don't shutdown node fix(protocol-perf): Allow client to drive performance Aug 14, 2023
@maschad maschad marked this pull request as ready for review August 14, 2023 18:29
@maschad maschad changed the title fix(protocol-perf): Allow client to drive performance fix(@libp2p/protocol-perf): Allow client to drive performance Aug 14, 2023
@maschad maschad changed the title fix(@libp2p/protocol-perf): Allow client to drive performance fix(@libp2p/protocol-perf): Allow client to drive performance benchmarking Aug 14, 2023
@maschad maschad changed the title fix(@libp2p/protocol-perf): Allow client to drive performance benchmarking fix(@libp2p/protocol-perf): allow client to drive performance benchmarking Aug 14, 2023
@maschad maschad changed the title fix(@libp2p/protocol-perf): allow client to drive performance benchmarking fix(@libp2p/protocol-perf): ensure only client calls measure performance Aug 14, 2023
@maschad maschad merged commit 8716555 into libp2p:master Aug 14, 2023
20 of 22 checks passed
@maschad maschad deleted the fix/protocol-perf-node-shutdown branch August 14, 2023 21:52
@achingbrain
Copy link
Member

Please can you check the state of the build before merging PRs.

The previous commit merged would have performed a release. One of the interop tests timed out which means the release didn't happen.

Now this commit is the head of master so release-please will not (may not?) perform the release since it's no longer the tip of the tree.

In general please do not merge to master when master is red.

@maschad
Copy link
Member Author

maschad commented Aug 15, 2023

My apologies, noted. Perhaps another way to articulate it is we should ensure our releases are successful before merging to master.

This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants