-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubSub example ends with TypeError on Windows 10 (64-bit) #338
Comments
It looks like this was introduced in #313. The issue with enabling the dht by default is that we don't package a dht module with libp2p. So if the dht is not configured, libp2p errors on startup, which is the case in the pubsub example. The dht change should probably be reverted. Perhaps an alternative route to enabling it by default would be to add some pre-configured bundles to libp2p with clear |
I think we should keep it enabled by default, taking into consideration that we want people to start using it, in order to allow the implementation to be exposed to a bigger network. In this way, I think that we should go with the |
My thought is to revert it for the 0.25 release, so that it doesn't block the js-ipfs release, as I'd prefer not to rush the bundle work. With it being enabled by default in the upcoming js-ipfs release, if we target the bundles and having it on by default for the next libp2p 0.26 release, we'd get a little more time to talk through the bundle options and still get more dht exposure via ipfs. |
All right, that's fine for me! We can go that way then :) |
fix: correct transport config check
fix: correct transport config check
This is no longer an issue. |
Type: Bug
Severity: Low
Description: The PubSub example ends with a TypeError:
Steps to reproduce the error:
npm install
to install all dependencies.npm audit fix
to attempt to fix 3 low-priority vulnerabilities. Result:(I can update this issue with details on the reported vulnerabilities--please let me know if it's relevant)
{trunk}\examples\pubsub
runnode 1.js
(nodejs 1.js
on Ubuntu) -- after a few moments the error is reported and example terminates.The text was updated successfully, but these errors were encountered: