chore: apply suggestions from code review

Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
libp2p · Apr 6, 2021 · f510e8f · f510e8f
1 parent c92a92c
commit f510e8f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/ip-port-to-multiaddr.js b/src/ip-port-to-multiaddr.js
@@ -21,8 +21,9 @@ function ipPortToMultiaddr (ip, port) {
     throw errCode(new Error(`invalid ip provided: ${ip}`), errors.ERR_INVALID_IP_PARAMETER)
   }
 
-  // @ts-ignore parseInt expects only string
-  port = parseInt(port)
+  if (typeof port === 'string') {
+    port = parseInt(port)
+  }
 
   if (isNaN(port)) {
     throw errCode(new Error(`invalid port provided: ${port}`), errors.ERR_INVALID_PORT_PARAMETER)

diff --git a/src/stream-to-ma-conn.js b/src/stream-to-ma-conn.js
@@ -34,7 +34,7 @@ function streamToMaConnection ({ stream, remoteAddr, localAddr }, options = {})
      */
     async sink (source) {
       if (options.signal) {
-        // @ts-ignore abortable has no type definitions
+        // @ts-ignore ts infers source template will be a number
         source = abortable(source, options.signal)
       }
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,9 +1,9 @@
 {
-  "extends": "./node_modules/aegir/src/config/tsconfig.aegir.json",
+  "extends": "aegir/src/config/tsconfig.aegir.json",
   "compilerOptions": {
     "outDir": "dist"
   },
   "include": [
     "src"
   ]
-}
+}