This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: reduce async iterator loops per package in _createSink #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
added
the
need/maintainer-input
achingbrain
added
need/author-input
achingbrain
suggested changes
Nov 23, 2022
There was a problem hiding this comment.
I'm not seeing a huge amount of difference in the benchmarks for this repo with the change in this PR applied.
I ran the benchmark 5x times for each branch and took the best result and they look similar enough to me that I'd err on the side of code readability here:
master:
% node benchmark/send-and-receive.js
send and receive x 210,311 ops/sec ±0.19% (98 runs sampled)
Fastest is send and receivereduce-loops-sink:
% node benchmark/send-and-receive.js
send and receive x 210,287 ops/sec ±0.16% (100 runs sampled)
Fastest is send and receiveDo you have a benchmark that shows a performance improvement with this change?
That branch proves a non-zero cost of async iterables. The goal is progressively reduce the count of async iterables calls or total promises allocated per paquet progressively through the entire libp2p stack. |
achingbrain
changed the title
achingbrain
approved these changes
Nov 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
## [7.0.6](v7.0.5...v7.0.6) (2022-11-25) ### Bug Fixes * reduce async iterator loops per package in _createSink ([#224](#224)) ([e2a32ad](e2a32ad)), closes [/github.com/libp2p/js-libp2p/issues/1420#issuecomment-1273272662](https://github.com/libp2p//github.com/libp2p/js-libp2p/issues/1420/issues/issuecomment-1273272662)
|
🎉 This PR is included in version 7.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript abstractions are not free. While using pipe here looks nice, it adds a non-neglible cost allocating Promises for each extra
for await ()iteration.This PR merges sink pipe components in a single iteration