Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Multiaddr formatter doesn't work #35

Closed
achingbrain opened this issue Jun 2, 2023 · 2 comments · Fixed by #36
Closed

Multiaddr formatter doesn't work #35

achingbrain opened this issue Jun 2, 2023 · 2 comments · Fixed by #36
Labels
released

Comments

@achingbrain
Copy link
Member

The formatter added in #34 doesn't work:

Code:

log('%ma is externally dialable', addr)

Log output:

libp2p:autonat a is externally dialable +0ms

cc @maschad @MarcoPolo
maschad added a commit to maschad/js-libp2p-logger that referenced this issue Jun 2, 2023
@maschad
fix: specify updated formatter for multiaddrs (libp2p#35)
64d3e58
@maschad maschad mentioned this issue Jun 2, 2023
Merged
@maschad
Copy link
Member

maschad commented Jun 2, 2023 •
edited
Loading

Good catch, since debug-js uses printf-style formatting, %ma wouldn't work. I pushed a fix.

maschad added a commit to maschad/js-libp2p-logger that referenced this issue Jun 2, 2023
@maschad
test: added test to ensure debug prints the correct format (libp2p#35)
a2ccf30
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: specify updated formatter for multiaddrs maschad/js-libp2p-logger
2 participants
@achingbrain @maschad