This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
package.json - fix main reference #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haadcode
reviewed
Oct 20, 2016
| @@ -2,7 +2,7 @@ | |||
| "name": "libp2p-floodsub", | |||
| "version": "0.3.0", | |||
| "description": "libp2p-floodsub, also known as pubsub-flood or just dumbsub, this implementation of pubsub focused on delivering an API for Publish/Subscribe, but with no CastTree Forming (it just floods the network).", | |||
| "main": "lib/core/index.js", | |||
| "main": "src/core/index.js", | |||
There was a problem hiding this comment.
I believe this should be "main": "src/index.js".
haadcode
suggested changes
Oct 20, 2016
|
Actually, take that back. pointing to |
|
yep, it should be lib, that is what gets published. See https://github.com/ipfs/community/blob/master/js-project-guidelines.md |
|
oh! build-and-publish. gotcha. I think `"main": "dist/index.js" would be more clear, but may be difficult to change that at this point. |
|
@kumavis it's not ideal, but we have a plan of moving to |
|
@dignifiedquire thanks! just got off a call with @diasdavid and he explained the situation in depth |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.