test: default to noise in tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're still using go libp2p 0.8.1 (latest is 0.10.0), we should update this. It would be nice to get CI to just pull go and install instead of fetching the binaries. |
vasco-santos
approved these changes
Jun 26, 2020
|
We are block on the go daemon PR libp2p/go-libp2p-daemon#233.
The main issue for that is that we need the daemon updated and not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the test daemons to default to running noise instead of secio. Basic connection tests for the 3 key types are still being run for both secio and noise.
Ref:
go-libp2p defaulting to Noise libp2p/go-libp2p#972