Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Add mutex for write/close #65

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add mutex for write/close #65

merged 1 commit into from
Dec 17, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Dec 17, 2019

Closes #56

@vyzo vyzo requested a review from Stebalien December 17, 2019 11:49
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO and I want to live.

@Stebalien Stebalien merged commit 370d1a3 into master Dec 17, 2019
@Stebalien Stebalien deleted the fix/issue-56 branch December 17, 2019 11:59
@Stebalien
Copy link
Member

@aarshkshah1992 we added this lock to prevent a concurrent write panic. However:

  1. We should never be calling Write concurrently, as far as we know.
  2. It should be safe to call Write and Close concurrently.

We'd still like to know why this was an issue because we're pretty sure this isn't the right fix. If you're bored, want to try looking into this? Don't spend too much time as multiple people have already sunk quite a bit of time trying to figure this out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: concurrent write to websocket connection
2 participants