extract buffer pool (and simplify interface)

[Stebalien]

New go-buffer-pool repo: libp2p/go-buffer-pool.

[kevina]

@Stebalien This is doing a bit more then just an extraction. Are there any others packages that use the the buffer pool from this package?

[Stebalien]

Yes and I will fix them as well. The interface just really sucked.

[kevina]

Okay, it is difficult for me to review this without seeing what changed in the buffer pool code. I attempted to push tags to make a pull request out of the changes, but github is refusing, likely because the code is already in master. At very least you can see the changes in go-buffer-pool from the extraction:

libp2p/go-buffer-pool@pre-extract...master
libp2p/go-buffer-pool@pre-extract...post-extract

Maybe if we reset master to pre-extract we can create a proper pull request for review...

[Stebalien]

Okay, it is difficult for me to review this without seeing what changed in the buffer pool code. I attempted to push tags to make a pull request out of the changes, but github is refusing, likely because the code is already in master.

I recommend you simply review it as new code. The new code is simpler than the old code.

If you actually want to see the diff, you can look at everything since 5ef65a036f9c5254313d3e123b3fe6c4b6bcad6e (git diff 5ef65a036f9c5254313d3e123b3fe6c4b6bcad6e..master).

(it's about 50 lines of actual code).

[Stebalien]

@bigs

Can you take a look at this? I finally yoloed whyrusleeping/yamux#5 so we now have two buffer pools (as that PR uses the buffer pool from the new go-buffer-pool package).

[Stebalien]

Blocked on:

• switch to go-buffer-pool ipfs/go-ipfs-chunker#8
• switch to go-buffer-pool go-libp2p-pnet#24
• switch to go-buffer-pool go-mplex#31
• switch to the buffer-pool package go-libp2p-secio#30

[bigs]

lgtm!