Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch panics in handleIncoming and handleOutgoing #109

Merged
merged 1 commit into from
Apr 18, 2022
Merged

catch panics in handleIncoming and handleOutgoing #109

merged 1 commit into from
Apr 18, 2022

Conversation

marten-seemann
Copy link
Contributor

No description provided.

Stebalien
Stebalien approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I'd consider just putting this logic inside handleIncoming and handleOutgoing.

@marten-seemann
Copy link
Contributor Author

Done.

@marten-seemann marten-seemann merged commit eca6a52 into master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @Stebalien