swarm: add deadline for connection setup #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| deadline = time.Now().Add(ConnSetupTimeout) | ||
| } | ||
|
|
||
| if err := connC.SetDeadline(deadline); err != nil { |
There was a problem hiding this comment.
Got it, you use the SetDeadline like a timeout :)
re: adding SetDeadline for muxed streams - A muxed stream should not timeout, since a conn was already established, so do we really need to make it part of the API?
There was a problem hiding this comment.
@diasdavid can you guarantee that the other side is going to read when you write? I can OOM your node by opening up lots of streams to it and just holding on to them
There was a problem hiding this comment.
Good point. Is SetDeadline the best way to solve it? Seems a thing that helps towards the solution, but it would be nice to have a way to tell when to close connections and with which criteria.
whyrusleeping
added
need/review
whyrusleeping
force-pushed
the
fix/add-conn-setup-deadline
branch
from
f88e2aa
to
9441754
Compare
marten-seemann
added a commit
that referenced
this pull request
Apr 27, 2022
sync: update CI config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.