Feat/protocol prefs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/protocol-prefs
branch
2 times, most recently
from
57fa777
to
0aaf4cf
Compare
|
it appears theres actually a problem on osx here |
whyrusleeping
force-pushed
the
feat/protocol-prefs
branch
from
0aaf4cf
to
287383a
Compare
|
alright, fixed the osx thing, apparently it was slower for OSX to close out the socket than on linux. @Kubuxu wanna review? |
|
Can you add me to libp2p org so I can assign myself? |
|
invite sent |
|
The one thought I had here is that the preference logic should probably be moved into the peerstore. |
|
@Kubuxu still review this, but i'm gonna merge it so i can move forward here. |
|
LGTM, it would be worth to use |
|
@Kubuxu yeah, i was thinking that too. we can do that later, it was kindof awkward to do the casting between the peerstore and multistream code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for remembering which of a set of protocols works for a given peer. It also uses protocols learned from the identify handshake to seed this knowledge if available.