Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer naming of nat override options #878

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Clearer naming of nat override options #878

merged 1 commit into from
Apr 9, 2020

Conversation

willscott
Copy link
Contributor

fix #874

options.go Outdated Show resolved Hide resolved
@Stebalien Stebalien requested review from Stebalien and daviddias and removed request for Stebalien April 8, 2020 17:32
@Stebalien
Copy link
Member

@daviddias better?

@daviddias
Copy link
Member

Not 100% sure, will sleep on it. I think the thing that makes it look foreign is that even for a Networks person, "reachability" as a property is not directly associated with NAT'ed vs. Public IPs. So it is a stepping stone to learn about, not huge though and the docs do help :)

@Stebalien
Copy link
Member

I think the thing that makes it look foreign is that even for a Networks person, "reachability" as a property is not directly associated with NAT'ed vs. Public IPs.

That's actually what this option is trying to capture. The "AutoNAT" service is really trying to determine "am I directly reachable from the public internet", not "am I behind a NAT".

@willscott willscott merged commit fee77aa into master Apr 9, 2020
@willscott willscott deleted the bug/natoptions branch April 9, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename WithReachability option
3 participants