EnableAutoRelay should work without ContentRouting if there are StaticRelays defined #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e static relays configured
willscott
approved these changes
Feb 28, 2020
| } else { | ||
| _ = relay.NewAutoRelay(swrm.Context(), h, discovery, router, cfg.StaticRelays) | ||
| if router == nil { |
There was a problem hiding this comment.
potentially combined with previous line into } else if router == nil {
Stebalien
approved these changes
Feb 29, 2020
|
Please update the (already very confusing) docs: https://godoc.org/github.com/libp2p/go-libp2p#EnableAutoRelay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that if static relays are passed in to the
AutoRelayconstructor we should be able to construct anAutoRelayeven when there are noContentRoutingimplementations passed in.@willscott ran into this issue when trying to construct testground integration tests of autorelay. We can hack around it by passing in a
Null ContentRouterimplementation, but that seems incorrect.