Fix racy and failing test cases #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
commented
Jul 10, 2019
| @@ -368,7 +374,7 @@ func TestStreamsStress(t *testing.T) { | |||
| ctx := context.Background() | |||
| nnodes := 100 | |||
| if detectrace.WithRace() { | |||
| nnodes = 50 | |||
| nnodes = 30 | |||
There was a problem hiding this comment.
This is OK (and even better) because we're stress testing streams, and reducing the host count increases stream density per host.
|
Tests are green 💚🎉 (although |
raulk
requested review from
Stebalien and
vyzo
and removed request for
Stebalien
Stebalien
reviewed
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671, fixes #672, and integrates a peerstore fix to prevent a race.