New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic_host: ensure we close correctly when the context is canceled #656

Merged

Stebalien merged 1 commit into master from fix/closing-connmgr

Jun 13, 2019

Member

Stebalien commented Jun 13, 2019 •

edited

Loading

As long as we accept a context, we need to obey it.

fixes libp2p/go-libp2p-connmgr#49


          basic_host: ensure we close correctly when the context is canceled

As long as we _accept_ a context, we need to obey it.

Stebalien mentioned this pull request

Why manager's constructor does not receive context? libp2p/go-libp2p-connmgr#49

Closed

Stebalien requested a review from vyzo

June 13, 2019 18:34

vyzo approved these changes

View reviewed changes

Stebalien merged commit f2cdce7 into master

Stebalien deleted the fix/closing-connmgr branch

June 13, 2019 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet