Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cancelable background context in identify #624

Merged
merged 1 commit into from
May 7, 2019
Merged

Use cancelable background context in identify #624

merged 1 commit into from
May 7, 2019

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented May 7, 2019

So that we don't spawn extra goroutines on identify push to handle cancellation.

@vyzo vyzo requested a review from Stebalien May 7, 2019 18:34
@ghost ghost assigned vyzo May 7, 2019
@ghost ghost added the status/in-progress In progress label May 7, 2019
@Stebalien Stebalien merged commit 471b72f into master May 7, 2019
@ghost ghost removed the status/in-progress In progress label May 7, 2019
@Stebalien Stebalien deleted the fix/identify-context branch May 7, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees

@vyzo vyzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @Stebalien