autorelay: break findRelays into multiple functions and avoid the goto #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
(@Stebalien is picky and opinionated...)
Stebalien
force-pushed
the
chore/cleanup-autorelay
branch
from
88e02ea
to
776a53a
Compare
vyzo
requested changes
Apr 21, 2019
| continue | ||
| } | ||
| ar.mx.Unlock() | ||
| update = ar.tryRelay(ctx, pi) || update |
There was a problem hiding this comment.
BUG: this will potentially connect to ALL the relays.
There was a problem hiding this comment.
We need to count and break if we have more than desiredRelays.
There was a problem hiding this comment.
Or alternatively compare numRelays() >= DesiredRelays.
There was a problem hiding this comment.
I am going to fix it with numRelays >= DesiredRelays comparison since you seem to have an aversion to counters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(@Stebalien is picky and opinionated...)