feat(websocket): switch the underlying http server logger to use ipfs/go-log #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the box 😅.
The motivation behind this change is that while implementing ipfs/kubo#10521 I noticed a large number of logs of the form
"http: TLS handshake error from ip:port: EOF"and I couldn't control them in the same way I can logs for any other transport.This error in particular is one I don't expect many folks have run into since my understanding is that the WSS listener within go-libp2p is not highly utilized with many applications dependent on WSS choosing to use WS + do TLS termination in front of the libp2p node instead. However, in the linked issue the idea is to do the TLS termination within go-libp2p and so the issue becomes apparent.